Open
Conversation
… flax_ensemble_reset_params
… flax_ensemble_reset_params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Part of ensemble/flax flax.nnx support and parameter reset
Motivation and Context
To reset an object we check if "rngs" is in the
obj.__init__.__code__.co_varnames:__init__parameters are gathered. After adding a new "rngs" to these parameters theobj.__class__can be called with the parameters, resulting in re-initialization.However, when the main model class is being traversed and has the
__init__argumentsrngsas well asin_featuresfor example, the main class gets completely reinitialized with the "wrong"in_featuresin this instance.In this approach it is checked whether an obj has children via
if any(obj.iter_children()). When this is negated we can tell when the obj is a leaf, therefore being a candidate to be reset.Public API Changes
method.ensemble.flax:Addition of reset_traverser and key functionality.
method.ensemble.torch,method.ensemble.sklearnandmethod.ensemble.common:Addition of kwargs to support seed and rngs input required for
ensemble.flax.How Has This Been Tested?
With
tests.probly.method.ensemble.test_flax, testing parameter reset and difference in output after re-initialization.Checklist
CHANGELOG.md(if relevant for users).