Skip to content

fix(messaging): pass through PDF attachments#386

Open
huntharo wants to merge 2 commits into
mainfrom
codex/messaging-pdf-pass-through
Open

fix(messaging): pass through PDF attachments#386
huntharo wants to merge 2 commits into
mainfrom
codex/messaging-pdf-pass-through

Conversation

@huntharo
Copy link
Copy Markdown
Contributor

Summary

  • I changed messaging PDF ingestion to pass PDFs through as native file input instead of extracting PDF text.
  • I added shared file input/message-part contracts and wired Codex, Grok, replay persistence, and transcript rendering around file metadata.
  • I updated the messaging docs and added focused coverage for PDF pass-through, AI SDK file parts, controller routing, and replay sanitization.

Verification

  • I ran pnpm test apps/desktop/src/main/__tests__/messaging-attachment-processor.test.ts apps/desktop/src/main/__tests__/messaging-controller.test.ts packages/agent-core/src/__tests__/ai-sdk-message-builder.test.ts packages/agent-core/src/__tests__/session-state.test.ts.
  • I ran pnpm typecheck.
  • I ran pnpm lint:boundaries.

Notes

@huntharo
Copy link
Copy Markdown
Contributor Author

Addressed the Codex protocol concern from review. I checked the installed Codex Desktop bundle: non-image files are treated as local file references, with prompt context listing the saved paths, rather than raw file UserInput variants. This branch now mirrors that at the Codex adapter boundary: file inputs are written to a temp path and sent as text context + a mention, so turn/start never includes an unsupported type: file item. Grok still receives native file inputs.

@huntharo huntharo force-pushed the codex/messaging-pdf-pass-through branch 2 times, most recently from 2d4a98e to 14ddd51 Compare May 15, 2026 22:22
@huntharo huntharo force-pushed the codex/messaging-pdf-pass-through branch from 14ddd51 to 016cf95 Compare May 19, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant