fix(desktop): hydrate completed commentary messages#451
Open
huntharo wants to merge 1 commit into
Open
Conversation
huntharo
force-pushed
the
fix/completed-commentary-hydration
branch
from
a314d43 to
760ce53
Compare
huntharo
force-pushed
the
fix/completed-commentary-hydration
branch
from
760ce53 to
010d104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed a live transcript bug where a partial assistant commentary delta could remain visible after the app received the full completed
agentMessageitem.The renderer now treats completed commentary
agentMessageitems as authoritative, replaces the matching pending assistant message, and preserves the existing sequence/turn metadata so the transcript renders the full message instead of a suffix likeis still running too....Verification
I verified this with:
pnpm vitest run --config vitest.workspace.ts apps/desktop/src/renderer/src/lib/__tests__/useThreadSessionState.test.tsxpnpm --filter @pwragent/desktop typecheckpnpm --filter @pwragent/desktop test:e2e e2e/release-transcript-agent-message-completion.spec.tsThe Electron replay reproduces the observed bad partial message first, then verifies the completed full
agentMessagereplaces it in the transcript.