fix(desktop): restore slash autocomplete after query edits#629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/re, editing back to/r, then returning to/reso/reviewstays visible.Root Cause
Slash autocomplete stored an exact dismissed key such as
slash:0:3:/re. Editing to/rproduced a different key and reopened the popup, but typing/reagain matched the stale dismissed key and suppressed the Commands list even though/reviewstill matched.Validation
pnpm test apps/desktop/src/renderer/src/features/composer/__tests__/composer.test.tsx -t "reopens slash autocomplete"pnpm test apps/desktop/src/renderer/src/features/composer/__tests__/composer.test.tsx -t "slash review|slash autocomplete|slash commands|compact slash|provider-native skill commands"pnpm test apps/desktop/src/renderer/src/features/composer/__tests__/composer.test.tsxpnpm --filter @pwragent/desktop typecheck