fix(codex): preserve local environment hydration#649
Open
huntharo wants to merge 1 commit into
Open
Conversation
43343cc to
a70514d
Compare
a70514d to
f30b61e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the local Codex environment setup result so future local Codex App Server threads can run with the same toolchain context instead of rediscovering
nvm,pnpm, Corepack, and related PATH state on every command.Changes
.codex/environments/*.tomlsetup.thread/startthroughconfig.shell_environment_policy.set.thread/startpayload generation.Root Cause
PwrAgent ran environment setup commands in a child shell, but the resulting shell state could not mutate the parent Electron process or the Codex App Server thread config. That left local Codex turns with only the default process/login shell environment, so tools installed through project-specific version managers could be missing.
Validation
./node_modules/.bin/tsc --noEmit -p apps/desktop/tsconfig.json./node_modules/.bin/vitest run apps/desktop/src/main/__tests__/codex-environment-runtime.test.ts apps/desktop/src/main/__tests__/codex-client.test.tsgit diff --check