refactor: move the operator tests next to the modules they exercise - #254
Merged
Conversation
The 766-line operator/tests.rs sat at a re-export-only parent and covered both children. Split along the design/schwarz seam; the design_of fixture becomes Design::from_levels_for_test, matching CrossTab::from_dense_for_test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operator/tests.rswas the crate's largest file (766 lines) and the onlytests.rsat a parent that owns none of the symbols under test —operator.rsis a re-export shell. It covered bothdesignandschwarz, split internally along exactly that seam.Now
operator/design/tests.rsandoperator/schwarz/tests.rs, matching the other seventests.rsin the crate.The one non-mechanical part:
design_ofwas shared across the seam (via a qualifiedsuper::design_ofcall in the schwarz half), so it moves to its owning type asDesign::from_levels_for_test, followingCrossTab::from_dense_for_test. Importing it across the two test modules would have re-created the sibling edge the split removes.Tests-only; no production code paths touched. 98/98 pass, clippy and fmt clean.