Skip to content

fix functional tests - #154

Merged
pm-blanco merged 1 commit into
pyMBE-dev:mainfrom
pm-blanco:fix_functional_tests
Aug 14, 2026
Merged

fix functional tests#154
pm-blanco merged 1 commit into
pyMBE-dev:mainfrom
pm-blanco:fix_functional_tests

Conversation

@pm-blanco

@pm-blanco pm-blanco commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes issues with the functional tests cph_ideal_tests and weak_polyelectrolyte_dialysis_test:

  1. cph_ideal_tests was failing due to a small discrepancy in one data point (0.19952377 absolute error)
  • It was fixed by simply slightly increasing the sampling for the test. This has no significant impact on the overall run time of the functional costs since this test is still the less expensive.
  • A curious observation is that this test ran without issue on Espresso 4.2.2 but started failing when we migrated to 5.0.0. Might simply reflect a change in the rng as @jngrad suggested.
  1. weak_polyelectrolyte_dialysis_test was failing due to a regresion introduced in Increasing pyMBE interoperability (part I) #151 when a reference data set was removed by mistake.

@pm-blanco pm-blanco added this to the pyMBEv2.0.0 milestone Aug 14, 2026
@pm-blanco
pm-blanco requested a review from jngrad August 14, 2026 10:34
@pm-blanco pm-blanco self-assigned this Aug 14, 2026
@pm-blanco pm-blanco added the bug Something isn't working label Aug 14, 2026
@jngrad

jngrad commented Aug 14, 2026

Copy link
Copy Markdown
Member

@jngrad jngrad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pm-blanco
pm-blanco merged commit f20b221 into pyMBE-dev:main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants