Skip to content

Changelog entry for PR #5208#5227

Closed
wenqing wants to merge 1 commit into
pybind:masterfrom
wenqing:a_fixing
Closed

Changelog entry for PR #5208#5227
wenqing wants to merge 1 commit into
pybind:masterfrom
wenqing:a_fixing

Conversation

@wenqing

@wenqing wenqing commented Jul 6, 2024

Copy link
Copy Markdown
Contributor

Description

This PR adds the missed changelog entry for PR #5208.

Suggested changelog entry:

* A missing ``#include <algorithm>`` in pybind11/typing.h was added, to
  fix a GCC 14 build error.
  `#5200 <https://github.com/pybind/pybind11/pull/5208>`_

fixes a compilation error with gcc 14.
@rwgk

rwgk commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

Thanks @wenqing but this will be handled semi-automatically when we make future releases. The Changelog entries are harvested from the PR descriptions (and then maybe hand-curated in bulk). Look for make_changelog here:

https://github.com/pybind/pybind11/blob/bb05e0810b87e74709d9f4c4545f1f57a1b386f5/docs/release.rst

@rwgk rwgk closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants