Skip to content

Update to add pybamm's cache_esoh option#913

Draft
NicolaCourtier wants to merge 4 commits intodevelopfrom
updates-for-pybamm
Draft

Update to add pybamm's cache_esoh option#913
NicolaCourtier wants to merge 4 commits intodevelopfrom
updates-for-pybamm

Conversation

@NicolaCourtier
Copy link
Member

Description

Enable passing of the cache_esoh option, following the updates to pybamm.Simulation in PyBaMM PR 5408.

Wait until the next PyBaMM release before merging.

Fixes #906, #907, #908, #909.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (4628a65) to head (b1de7dc).
⚠️ Report is 43 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #913      +/-   ##
===========================================
+ Coverage    89.41%   92.86%   +3.45%     
===========================================
  Files           63       73      +10     
  Lines         4857     5679     +822     
===========================================
+ Hits          4343     5274     +931     
+ Misses         514      405     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant