BLD: migrate build backend to meson-python#556
Conversation
679039b to
fd49952
Compare
|
I reached a somewhat functional state where at least some jobs are passing.
|
|
looks like this is what's failing windows-arm64 jobs: astral-sh/uv#12906 |
|
got a bit further using the workaround described in the issue I just linked. Now meson correctly detects a native Python interpreter, but then hit which I don't understand yet |
ad2a594 to
64d6587
Compare
rgommers
left a comment
There was a problem hiding this comment.
I had a quick looks; this looks like a good start to me.
| 'nonreduce_axis', | ||
| [ | ||
| bn_config_h, | ||
| custom_target( |
There was a problem hiding this comment.
If you define a generator, this can be a one-liner per file, same as in for example:
There was a problem hiding this comment.
a generator is how I initially tried to write this but I struggled to define a template for the output filename, because it's obtained by subtraction rather than addition.
There was a problem hiding this comment.
Could rename the source files? They're not valid C code, so .c.in or .c.template seems more accurate anyway
There was a problem hiding this comment.
Yes, I was thinking doing just that as a cleanup step after I got CI stable again. Though I prefer extensions like .template.c, as it allows syntax highlighting to sort-of work instead of not at all.
There was a problem hiding this comment.
actually went for it tonight because I had limited bandwidth and this didn't require much. I ended up using your suggestion (.c.template) because I couldn't work out how to implement .template.c using available substitutions .
11ff03d to
fc3f675
Compare
|
I'm hesitant to just drop windows-arm64 as a normal CI target. It works in the context of cibw but I'm struggling to set it up using |
1da1f28 to
5f82a22
Compare
00e1e4f to
7f54ef5
Compare
|
I got lost as I tried to get everything working at the same time. I've disabled limited-api builds for now because I found it hard to setup correctly with 3.14t also being a target. I'm also disabling failing targets as I go right now, with the goal to reveal the subset that does work already, before I tackle failures one by one again. |
1a1dce8 to
d99ca68
Compare
|
I was able to re-enable 2/3 windows targets. The remaining failing one is |
16e76e7 to
7f99a4b
Compare
|
phew, I was able to fix it using the wisdom of this comment mesonbuild/meson-python#610 (comment) I think this is ready for review now.
TBD ! |
|
|
I don't care about it either way (
There shouldn't be any hiccups as long as it's a native run on arm64 runners I believe. On x86-64 runners, meson will treat it by default as a cross compile.
I'll note that I'm on holiday until the end of next week and mostly camping, so I might not get to this until after that. |
|
thanks for the headsup. And no worries, this has been on the back of my mind for years, I can definitely wait a week longer 😄 |
note to self: I forgot that we didn't run the test suite in cibw, so, even though building works, I cannot confirm that nothing breaks yet. |
This is based off #511
close #516
very much a work in progress.
When attempting a build with
I get 2 errors about
mallocandfreebeing undefined. Here's the first one:I don't understand how this happens,
#include <stdlib.h>is already present inbottleneck/src/reduce_template.c.If I run
uv buildinstead, I getso clearly I must be doing something wrong, but I'm not too surprised because this is the first time I attempt to hook python scripts into a meson build.