Turn of successful githab CI notifications for Discord#154
Open
aryan-neogi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #152
This PR adds support for filtering Discord notifications based on workflow success status.
Changes
fenn/notification/services/discord.pynotify_on_successparameter (default:False)should_notify()override to filter success notificationsfenn/notification/service.pyshould_notify()method for notification servicesfenn/notification/notifier.pynotify()to accept anis_successparametershould_notify()before sending notificationsTests
tests/unit/notification/test_discord_service.pyAdded tests covering notification filtering behavior:
notify_on_success=Falsenotify_on_success=Trueshould_notify()logicResult
Discord notifications can now be configured to only send on failures, reducing notification noise while preserving existing behavior through configuration.