fix: use official zookeeper Docker image#10
Merged
Conversation
Change from daocloud.io/zookeeper:3.4.10 to zookeeper:3.9 (official Docker Hub). The daocloud.io registry is inaccessible from GitHub Actions (returns HTTP 500).
Zookeeper 3.9 takes longer to start than 3.4.10, causing connection timeouts. Add wait_for_zk helper function that retries connection attempts until zookeeper is ready or timeout is reached.
ZOO_MY_ID and ZOO_SERVERS are only needed for cluster mode. For standalone mode (single node), these env vars may cause issues with zookeeper 3.9.
ZK 3.9 creates different system nodes under /zookeeper than older versions. Skip this node in test_export_hierarchy to make the test version-agnostic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daocloud.io/zookeeper:3.4.10tozookeeper:3.9(official Docker Hub)Files changed
Test plan
🤖 Generated with Claude Code