Skip to content

Easy optimisations#643

Open
LordIdra wants to merge 3 commits intomasterfrom
idra/easy-optimisations
Open

Easy optimisations#643
LordIdra wants to merge 3 commits intomasterfrom
idra/easy-optimisations

Conversation

@LordIdra
Copy link
Contributor

@LordIdra LordIdra commented Mar 4, 2026

Just some small changes which will speed things up hopefully a lot

  • Changed getSuppliedFluids to return a list of pairs, not a map - a map will probably be a lot slower since we are usually only dealing with like 1-3 elements
  • Changed fluid ticking code to avoid repeated BlockStorage calls for the same block and avoid filtering fluid points by type every tick - this was taking up a lot of time in spark profiles
  • Fix chunk unloading causing lots of errors due to BeaconDeactivateEvent being called

@Seggan
Copy link
Member

Seggan commented Mar 4, 2026

Have you actually profiled the first change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants