Merged
Conversation
ricardoV94
force-pushed
the
fix_flaky_cis
branch
2 times, most recently
from
4964756 to
fabfad1
Compare
This was referenced Nov 18, 2025
Closed
ricardoV94
force-pushed
the
fix_flaky_cis
branch
2 times, most recently
from
d1ae8ec to
d00db75
Compare
Member
Author
|
Many things seem broken with MLX, I suspect it's related to their recent release? https://github.com/ml-explore/mlx/releases/tag/v0.29.4 |
ricardoV94
force-pushed
the
fix_flaky_cis
branch
from
d00db75 to
97101c4
Compare
Open
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
========================================
Coverage 81.70% 81.71%
========================================
Files 246 251 +5
Lines 53632 54107 +475
Branches 9438 9468 +30
========================================
+ Hits 43822 44212 +390
- Misses 7329 7408 +79
- Partials 2481 2487 +6 🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
Nov 18, 2025
Member
|
Was the issue with pytorch tests resolved? |
Member
Author
Apparently. Testing the pin thing in #1720 |
cetagostini
approved these changes
Nov 18, 2025
Contributor
cetagostini
left a comment
cetagostini
left a comment
There was a problem hiding this comment.
Good 👍🏻 I was thinking in the same direction but didn't went to last release, I closed my PR. We can merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.