Facilitate graph pattern matching#1786
Open
ricardoV94 wants to merge 4 commits intopymc-devs:mainfrom
Open
Conversation
a7784e3 to
a85635f
Compare
ricardoV94
commented
Dec 12, 2025
| # Check for use of pt.diag first | ||
| case (AllocDiag(offset=0, axis1=axis1, axis2=axis2), diag_input): | ||
| ndim = diag_input.ndim | ||
| if axis1 == ndim - 1 and axis2 == ndim: |
Member
Author
There was a problem hiding this comment.
This is new, we were not checking for non standard allocdiagonal, not along the last dims!
e64cce7 to
e0bcea7
Compare
e0bcea7 to
e265141
Compare
e265141 to
c0839a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a POC for #1455
owner_opandowner_op_and_inputs.if x.owner.op is not None and isinstance(x.owner.op, ...)in favor ofisinstance(x.owner_op, ...)casestatement. This makes nested patterns easier to write. Eg.case (Blocwise(Dot()), a, b)for a singlematch x.owner_op_and_inputs.match_argsso common parametrized Ops (Elemwise, Blockwise) and Constants are easier to pattern match without kwargsis_matrix_transposeandis_left_expanded_matrix_transposeproperty to DimShuffle, for easier pattern matchingI then refactored the existing linalg rewrites as a POC. I went a bit overboard and tried to standardize names, and fuse rewrites that were pretty simple to combine.
CC @tanish1729 who did many of these rewrites, see if it feels nicer?