Implement vectorize for XTensor Ops#1876
Draft
ricardoV94 wants to merge 7 commits intopymc-devs:mainfrom
Draft
Conversation
ricardoV94
force-pushed
the
xtensor_vectorize
branch
2 times, most recently
from
94d0dfd to
3fdc609
Compare
ricardoV94
force-pushed
the
xtensor_vectorize
branch
from
3fdc609 to
6cc0475
Compare
…turn list of variables
ricardoV94
force-pushed
the
xtensor_vectorize
branch
from
3fb7e9c to
e06d0e3
Compare
ricardoV94
force-pushed
the
xtensor_vectorize
branch
from
e06d0e3 to
796ccf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Ops are undefined, but most things are pretty straightforward.
The biggest challenge is when vectorization would imply new dimensions (say
xtensor_from_tensor). There is no trivial way to allow the user to tell us what those dimension labels should be.And sized operations (where numerical inputs determine output sizes). However those are equally tricky in tensor graphs.
I decided to implement most methods as an Op property. I think this should be the default, as it keeps code organized. Users can still implement their custom dispatch if it's missing, and we can offer a two level dispatch (not to accidentally override the error checking that is now done for all Ops before dispatching)
Missing tests