Accept published_at field for CrossBuildEnvReleaseSpec and add publish date information to MetadataView#349
Conversation
agriyakhetarpal
changed the title
published_at field for CrossBuildEnvReleaseSpecpublished_at field for CrossBuildEnvReleaseSpec and add publish date information to MetadataView
|
Thanks. But this means the older versions of pyodide-build will suddenly stop working because of the remote metadata file change. I should've made pyodide-build robust on the spec changes... |
|
One workaround that I can think of is changing the metadata url, say, keeping the point to the old metadata file without the and then, we make a new and update the url in pyodide-build (+ allow extra keys) |
|
Oh, thanks for raising this. Good idea. I think we should loosen our requirements for the spec going forward at the same time, so that we don't need to introduce a v3 unless we really really need it... |
|
I'll update this PR with the changes in a bit! |
|
Okay, we didn't exactly need a lot of changes here. I'm keeping this as draft until we have the v2 URL live on GitHub Pages. |
This reverts commit f15d1c9.
- Adds a script to add v2 metadata for nightly cross-build environments in a JSON file (see generated JSON file) - The `publish.yml` workflow file now pushes a commit to `main`. I chose to not use a PR because it adds a bit of churn, but I can change the approach if asked - Added a `pages.yml` workflow to deploy the file on GitHub Pages There is no v1 file here, just v2, because it's the first time we are doing it and it doesn't make sense to go with the old spec. I will follow this up by putting together a PR in pyodide-build to use this metadata for those who would like to use nightly and nightly-debug builds. xref pyodide/pyodide#6248, pyodide/pyodide-build#349
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Thanks! Let's merge this after we start publishing v2 metadata. I left a minor comment otherwise looks good.
This reapplies commit 14500af.
Co-Authored-By: Gyeongjae Choi <def6488@gmail.com>
2 participants
This is a companion PR to pyodide/pyodide#6248. I'm trying to add metadata about when the cross-build environments are published, so consumers of such information can use it however they like.
CrossBuildEnvReleaseSpecnow takes in apublished_atfield with ISO 8601 timestampspublished_atfield. They are currently blank andnull, but will work once the corresponding Pyodide PR is merged and deployed to GitHub Pages, i.e., thepublished_atdates are included in the live JSON file.