Resolve sys.prefix symlinks when replacing host include paths#375
Merged
agriyakhetarpal merged 1 commit intoJun 12, 2026
Merged
Conversation
pthom
force-pushed
the
fix-pywasmcross-symlinked-prefix
branch
from
3e88e1a to
bd2590f
Compare
replay_genargs_handle_dashI now resolves symlinks before comparisons. This is required for homebrew Python (macOS), where sys.prefix contains symlinks.
pthom
force-pushed
the
fix-pywasmcross-symlinked-prefix
branch
from
bd2590f to
52c1923
Compare
agriyakhetarpal
approved these changes
Jun 12, 2026
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
Member
There was a problem hiding this comment.
Nice, thanks @pthom! I was also having this problem with Homebrew Python on my machine, but I didn't spend enough time debugging!
Would you like me to cut a release with this change?
Contributor
Author
If possible, yes. At the moment, I do have to patch pyodide-build manually. |
Member
|
Sorry for the trouble. Let me do so, then! |
Contributor
Author
|
Thank you very much for the quick release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374.
replay_genargs_handle_dashInow resolves symlinks for both include_path and sys.prefix before comparison.The added regression test (real symlink in
tmp_path) fails onmainand passes with this change.