chore: rework if TYPE_CHECKING: blocks#2869
Closed
mayeut wants to merge 3 commits into
Closed
Conversation
Member
Author
|
close in favour of #2866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2866 as proposed in #2866 (comment).
The 1st commit is #2866, it enforces the use of
if TYPE_CHECKING:blocks.The 2nd commit revert #2864 as it's not needed as noted in #2866 (comment) and might borderline regarding standards (it's apparently not even though it works in practice)
The 3rd commit removes enforcing
TCon tests as it's not likely useful there.Marking as draft until there's a consensus between #2866 and this one.