Implement is_unsatisfiable on SpecifierSet using intervals#1119
Open
notatallshaw wants to merge 4 commits intopypa:mainfrom
Open
Implement is_unsatisfiable on SpecifierSet using intervals#1119notatallshaw wants to merge 4 commits intopypa:mainfrom
is_unsatisfiable on SpecifierSet using intervals#1119notatallshaw wants to merge 4 commits intopypa:mainfrom
Conversation
notatallshaw
force-pushed
the
is-unsatisfiable/is_unsatisfiable
branch
from
5df83c0 to
8aabbca
Compare
notatallshaw
force-pushed
the
is-unsatisfiable/is_unsatisfiable
branch
2 times, most recently
from
b67de8d to
7991a09
Compare
Member
Author
|
I think this is ready for review, this attempts to be correct and implemented in an intuitive and as simple as possible way. This does not intended to be performant, while not slow, there are a lot of opportunities for performance, but usually at the cost of adding complexity or making less intuitive . |
notatallshaw
force-pushed
the
is-unsatisfiable/is_unsatisfiable
branch
2 times, most recently
from
f4dd692 to
ce9473c
Compare
notatallshaw
force-pushed
the
is-unsatisfiable/is_unsatisfiable
branch
from
ce9473c to
4b067f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #940
Fixes #306
This uses intervals that re-implement PEP 440 logic, the plan is to move the entire specifier machinery to use intervals, but that will be in a follow up PR. This approach focuses on relative simplicity, given that choice, and is not micro-optimized.
There are some edge cases around
===that need to still be decided on, as this PR implements something closer to the specification than packaging quite implements (see #978 and #766), I will create a follow up PR to make that choice directly.PR still needs a little clean up, so I will leave in draft for now and comment when ready for review.