Skip to content

fix: Update public export declarations from __init__.py files #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylebarron wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −17
Open

fix: Update public export declarations from __init__.py files #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6175145
fix: Declare public exports from `crs/__init__.py`
kylebarron Mar 6, 2026
e8c804e
update exports
kylebarron Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions pyproj/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,14 @@
from pyproj._context import ( # noqa: F401 pylint: disable=unused-import
set_use_global_context,
)
from pyproj._show_versions import ( # noqa: F401 pylint: disable=unused-import
show_versions,
)
from pyproj._show_versions import show_versions
from pyproj._version import ( # noqa: F401 pylint: disable=unused-import
PROJ_COMPILED_VERSION,
PROJ_COMPILED_VERSION_STR,
PROJ_VERSION,
PROJ_VERSION_STR,
)
from pyproj.crs import CRS # noqa: F401 pylint: disable=unused-import
from pyproj.crs import CRS
from pyproj.database import ( # noqa: F401 pylint: disable=unused-import
get_authorities,
get_codes,
Expand All @@ -59,17 +57,9 @@
geodesic_version_str,
pj_ellps,
)
from pyproj.list import ( # noqa: F401 pylint: disable=unused-import
get_ellps_map,
get_prime_meridians_map,
get_proj_operations_map,
)
from pyproj.proj import Proj, pj_list # noqa: F401 pylint: disable=unused-import
from pyproj.transformer import ( # noqa: F401 pylint: disable=unused-import
Transformer,
itransform,
transform,
)
Comment on lines -62 to -72
Copy link
Copy Markdown
Author

@kylebarron kylebarron Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is just removing the unnecessary noqa: F401 because all imports are used

from pyproj.list import get_ellps_map, get_prime_meridians_map, get_proj_operations_map
from pyproj.proj import Proj, pj_list
from pyproj.transformer import Transformer, itransform, transform

__version__ = "3.7.3.dev0"
__all__ = [
Expand All @@ -80,7 +70,6 @@
"get_ellps_map",
"get_prime_meridians_map",
"get_proj_operations_map",
"get_units_map",
Copy link
Copy Markdown
Author

@kylebarron kylebarron Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deprecated as exported from the top-level and is suggested to import from pyproj.database https://pyproj4.github.io/pyproj/stable/api/database.html#pyproj.database.get_units_map

"itransform",
"pj_ellps",
"pj_list",
Expand Down
7 changes: 6 additions & 1 deletion pyproj/crs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class.
"""

from pyproj._crs import ( # noqa: F401 pylint: disable=unused-import
Copy link
Copy Markdown
Author

@kylebarron kylebarron Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the noqa when all imports are used in __all__

from pyproj._crs import (
CoordinateOperation,
CoordinateSystem,
Datum,
Expand All @@ -30,10 +30,15 @@
"CRS",
"BoundCRS",
"CompoundCRS",
"CoordinateOperation",
"CoordinateSystem",
"CustomConstructorCRS",
"Datum",
"DerivedGeographicCRS",
"Ellipsoid",
"GeocentricCRS",
"GeographicCRS",
"PrimeMeridian",
Comment on lines +33 to +41
Copy link
Copy Markdown
Author

@kylebarron kylebarron Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these newly-added exports were already in the public docs for pyproj.crs

"ProjectedCRS",
"VerticalCRS",
"is_proj",
Expand Down