Skip to content

Fix a mismatched comment & implementation in CircuitTemplate.update_var()#47

Open
PC-DOS wants to merge 5 commits intopyrates-neuroscience:masterfrom
PC-DOS:master
Open

Fix a mismatched comment & implementation in CircuitTemplate.update_var()#47
PC-DOS wants to merge 5 commits intopyrates-neuroscience:masterfrom
PC-DOS:master

Conversation

@PC-DOS
Copy link
Contributor

@PC-DOS PC-DOS commented Jan 23, 2026

The comment in CircuitTemplate.update_var() says elements in the edge_vars list are tuple with 4 elements ((source, target, idx, edge_dict)), but the real implementation left idx in the for expression, causing problems.

Old expression:

        for source, target, edge_dict in edge_vars:
            _, _, _, base_dict = self.get_edge(source, target)
            base_dict.update(edge_dict)

Updated expression:

        for source, target, idx, edge_dict in edge_vars:
            _, _, _, base_dict = self.get_edge(source, target, idx)
            base_dict.update(edge_dict)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant