Fix a mismatched comment & implementation in CircuitTemplate.update_var()#47
Open
PC-DOS wants to merge 5 commits intopyrates-neuroscience:masterfrom
Open
Fix a mismatched comment & implementation in CircuitTemplate.update_var()#47PC-DOS wants to merge 5 commits intopyrates-neuroscience:masterfrom
PC-DOS wants to merge 5 commits intopyrates-neuroscience:masterfrom
Conversation
This reverts commit c414a05.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment in
CircuitTemplate.update_var()says elements in theedge_varslist are tuple with 4 elements ((source, target, idx, edge_dict)), but the real implementation leftidxin theforexpression, causing problems.Old expression:
Updated expression: