a memory leak occurs when createing a new type#9
Open
zaxrok wants to merge 2 commits intopyros-dev:masterfrom
Open
a memory leak occurs when createing a new type#9zaxrok wants to merge 2 commits intopyros-dev:masterfrom
zaxrok wants to merge 2 commits intopyros-dev:masterfrom
Conversation
Member
|
We need to keep travis test passing before we can merge anything, to make sure we don't break anything else... pleas compare with the master branch the tests that were passing and why they are not passing anymore... |
Member
|
I recently merge a long PR in master to get all tests passing with travis, and make it easy to see if a PR breaks something or not. Please rebase your branch on the recent master and we can ensure the tests are passing on travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new instance of RosSchemas manually and filled values to Field of marshmallow.Schema.
When I tested it, there was no memory growing.