Skip to content

a memory leak occurs when createing a new type#9

Open
zaxrok wants to merge 2 commits intopyros-dev:masterfrom
zaxrok:rs-155
Open

a memory leak occurs when createing a new type#9
zaxrok wants to merge 2 commits intopyros-dev:masterfrom
zaxrok:rs-155

Conversation

@zaxrok
Copy link
Copy Markdown

@zaxrok zaxrok commented Feb 6, 2018

I created a new instance of RosSchemas manually and filled values to Field of marshmallow.Schema.
When I tested it, there was no memory growing.

@asmodehn
Copy link
Copy Markdown
Member

asmodehn commented Feb 6, 2018

We need to keep travis test passing before we can merge anything, to make sure we don't break anything else... pleas compare with the master branch the tests that were passing and why they are not passing anymore...

@asmodehn
Copy link
Copy Markdown
Member

I recently merge a long PR in master to get all tests passing with travis, and make it easy to see if a PR breaks something or not.

Please rebase your branch on the recent master and we can ensure the tests are passing on travis.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants