Skip to content

[INFRAHELP-2529] feat: add exclude-commands #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrandonLWhite merged 14 commits into from
Sep 8, 2025
Merged

[INFRAHELP-2529] feat: add exclude-commands #73

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8d3c4fd
Bump actions/checkout from 4 to 5
dependabot[bot] Aug 12, 2025
513336a
Bump eslint from 9.26.0 to 9.34.0
dependabot[bot] Aug 25, 2025
053d945
Bump jest from 29.7.0 to 30.1.3
dependabot[bot] Sep 4, 2025
3fd480b
Bump actions/setup-python from 5 to 6
dependabot[bot] Sep 4, 2025
146cb25
Bump actions/setup-node from 4.4.0 to 5.0.0
dependabot[bot] Sep 4, 2025
a31cd36
chore: bump deps
ajaxbits Sep 5, 2025
edd166e
refactor: move from .eslintrc.json to eslint.config.cjs due to deprec…
ajaxbits Sep 5, 2025
cdfc8c7
chore: clean unused codepaths
ajaxbits Sep 5, 2025
7b6153a
feat: add determineSkips function
ajaxbits Sep 5, 2025
ea110f6
feat: add determineSkips tests
ajaxbits Sep 5, 2025
a38d366
feat: incorporate determineSkips
ajaxbits Sep 5, 2025
bf44fb3
feat: add tests for action-level skipCommands
ajaxbits Sep 5, 2025
9bf05fd
feat: add exclude-commands input to action
ajaxbits Sep 5, 2025
ba52ba8
chore: update readme
ajaxbits Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/check-dist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v4.4.0
uses: actions/setup-node@v5.0.0
with:
node-version-file: package.json
cache: npm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
units:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- run: npm ci
- run: npm test

# test action works running from the graph
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- uses: ./
id: discover
with:
Expand All @@ -42,14 +42,14 @@ jobs:

steps:
- name: Check out code
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Dump project object
run: |
echo '${{ toJson(matrix.project) }}'

- name: Setup Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version-file: ${{ matrix.project.path }}

Expand Down
303 changes: 302 additions & 1 deletion __snapshots__/find-python-projects.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing

exports[`find-python-projects Exports keys as instructed 1`] = `
{
Expand Down Expand Up @@ -48,6 +48,307 @@ exports[`find-python-projects Exports keys as instructed 1`] = `
}
`;

exports[`find-python-projects doesn't export commands we should globally skip 1`] = `
{
"paths": [
"test-fixtures/multi-project/project-1/pyproject.toml",
"test-fixtures/multi-project/project-2/pyproject.toml",
"test-fixtures/multi-project/project-4/pyproject.toml",
"test-fixtures/multi-project/project-5/pyproject.toml",
"test-fixtures/multi-project/project-6/pyproject.toml",
],
"projects": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
},
"directory": "test-fixtures/multi-project/project-1",
"exports": {},
"name": "sub-project-1",
"path": "test-fixtures/multi-project/project-1/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"something-arbitrary": "echo 'Example of arbitrary shell command'",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"commands": {
"install": null,
},
"directory": "test-fixtures/multi-project/project-4",
"exports": {},
"name": "sub-project-4",
"path": "test-fixtures/multi-project/project-4/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "pdm.backend",
"commands": {
"install": "pdm install",
},
"directory": "test-fixtures/multi-project/project-5",
"exports": {},
"name": "project-5",
"path": "test-fixtures/multi-project/project-5/pyproject.toml",
"pythonVersion": "==3.12.*",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
},
"directory": "test-fixtures/multi-project/project-6",
"exports": {},
"name": "sub-project-6",
"path": "test-fixtures/multi-project/project-6/pyproject.toml",
"pythonVersion": "^3.9",
},
],
"projects-by-command": {
"install": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
},
"directory": "test-fixtures/multi-project/project-1",
"exports": {},
"name": "sub-project-1",
"path": "test-fixtures/multi-project/project-1/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"something-arbitrary": "echo 'Example of arbitrary shell command'",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "pdm.backend",
"commands": {
"install": "pdm install",
},
"directory": "test-fixtures/multi-project/project-5",
"exports": {},
"name": "project-5",
"path": "test-fixtures/multi-project/project-5/pyproject.toml",
"pythonVersion": "==3.12.*",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
},
"directory": "test-fixtures/multi-project/project-6",
"exports": {},
"name": "sub-project-6",
"path": "test-fixtures/multi-project/project-6/pyproject.toml",
"pythonVersion": "^3.9",
},
],
"package": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"something-arbitrary": "echo 'Example of arbitrary shell command'",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
],
"something-arbitrary": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"something-arbitrary": "echo 'Example of arbitrary shell command'",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
],
},
}
`;

exports[`find-python-projects doesn't export commands we should skip for certain projects 1`] = `
{
"paths": [
"test-fixtures/multi-project/project-1/pyproject.toml",
"test-fixtures/multi-project/project-2/pyproject.toml",
"test-fixtures/multi-project/project-4/pyproject.toml",
"test-fixtures/multi-project/project-5/pyproject.toml",
"test-fixtures/multi-project/project-6/pyproject.toml",
],
"projects": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
},
"directory": "test-fixtures/multi-project/project-1",
"exports": {},
"name": "sub-project-1",
"path": "test-fixtures/multi-project/project-1/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"test": "poetry run pytest",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"commands": {
"install": null,
},
"directory": "test-fixtures/multi-project/project-4",
"exports": {},
"name": "sub-project-4",
"path": "test-fixtures/multi-project/project-4/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "pdm.backend",
"commands": {},
"directory": "test-fixtures/multi-project/project-5",
"exports": {},
"name": "project-5",
"path": "test-fixtures/multi-project/project-5/pyproject.toml",
"pythonVersion": "==3.12.*",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"test": "poe test",
},
"directory": "test-fixtures/multi-project/project-6",
"exports": {},
"name": "sub-project-6",
"path": "test-fixtures/multi-project/project-6/pyproject.toml",
"pythonVersion": "^3.9",
},
],
"projects-by-command": {
"install": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
},
"directory": "test-fixtures/multi-project/project-1",
"exports": {},
"name": "sub-project-1",
"path": "test-fixtures/multi-project/project-1/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"test": "poetry run pytest",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"test": "poe test",
},
"directory": "test-fixtures/multi-project/project-6",
"exports": {},
"name": "sub-project-6",
"path": "test-fixtures/multi-project/project-6/pyproject.toml",
"pythonVersion": "^3.9",
},
],
"package": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"test": "poetry run pytest",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
],
"test": [
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"package": "poetry bundle venv .package/",
"test": "poetry run pytest",
},
"directory": "test-fixtures/multi-project/project-2",
"exports": {},
"name": "sub-project-2",
"path": "test-fixtures/multi-project/project-2/pyproject.toml",
"pythonVersion": "^3.9",
},
{
"buildBackend": "poetry.core.masonry.api",
"commands": {
"install": "poetry install",
"test": "poe test",
},
"directory": "test-fixtures/multi-project/project-6",
"exports": {},
"name": "sub-project-6",
"path": "test-fixtures/multi-project/project-6/pyproject.toml",
"pythonVersion": "^3.9",
},
],
},
}
`;

exports[`find-python-projects finds projects 1`] = `
{
"paths": [
Expand Down
Loading
Loading