Conversation
seddonym
force-pushed
the
add-import-linter-contract
branch
from
825bb95 to
6fb4cc8
Compare
CodSpeed Instrumentation Performance ReportMerging #234 will not alter performanceComparing Summary
|
It's about time! This removes the skip_install from the check step in the toxfile. This seems to be necessary for lint-imports to pass, but it does slow down the check, so it might be worth figuring out if there is a different way we could do this.
seddonym
force-pushed
the
add-import-linter-contract
branch
from
6fb4cc8 to
fe5db0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an import linter contract for Grimp's layered architecture. (I didn't realise this wasn't already there!)