Merged
Conversation
LilyFirefly
force-pushed
the
refactor-graph-wrapper
branch
from
45d98ac to
09e802c
Compare
CodSpeed Instrumentation Performance ReportMerging #250 will not alter performanceComparing Summary
|
LilyFirefly
commented
Sep 5, 2025
seddonym
requested changes
Sep 8, 2025
Collaborator
seddonym
left a comment
seddonym
left a comment
There was a problem hiding this comment.
Thanks for this - I like some of the changes but am not sure about (i) the naming of PyPackageDependency and (ii) the removal of the graph wrapper. Happy to discuss as maybe I've misunderstood.
rust/src/graph/mod.rs
Outdated
| Err(GrimpError::ModuleNotPresent(_)) => { | ||
| Err(GrimpError::NoSuchContainer(name.into()))? | ||
| } | ||
| _ => panic!("unexpected error parsing containers"), |
LilyFirefly
force-pushed
the
refactor-graph-wrapper
branch
from
09e802c to
1cb7dbb
Compare
This requires renaming the `PackageDependency` already in the graph module.
This allows making previously unreachable code paths unrepresentable.
LilyFirefly
force-pushed
the
refactor-graph-wrapper
branch
from
1cb7dbb to
c17e3f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best reviewed and merged after #249.