Conversation
Prior to this, subsequent sibling packages in the contents string would be incorrectly nested under the directory the line above, due to an assumption that the contents string would be dedented. This takes account of that.
This doesn't change the implementation yet, but it prepares us for supporting namespace packages passed in.
This pushes the NamespacePackageEncountered error up the call stack into the use case.
Also switch to using abstract types as parameters
seddonym
force-pushed
the
arbitrary-root-packages
branch
from
7492153 to
0fcea6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by #267 which has a narrower scope.