Add just autofix and run formatters after autofixes#285
Merged
seddonym merged 2 commits intopython-grimp:mainfrom Dec 18, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #285 will not alter performanceComparing Summary
Footnotes
|
seddonym
approved these changes
Dec 18, 2025
Collaborator
seddonym
left a comment
There was a problem hiding this comment.
Thanks! Makes sense - I had assumed these would produce validly formatted code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Add tests for the change. In general, aim for full test coverage at the Python level. Rust tests are optional.
[ ] Add any appropriate documentation.
[ ] Add a summary of changes to the
latestsection at the top ofCHANGELOG.rst. (If it's not there, add it.)[ ] Add your name to
AUTHORS.rst.[ ] Run
just full-check.Follow up to a comment in #284.
Somewhat opinionated change is to always run the formatter after autofixes - I think this is more ergonomic though.
Again I lean against including this in the changelog.