Improve French translation#248
Conversation
merwok
commented
Apr 1, 2025
- fix number units translations
- use proper decimal separator
| msgstr "e" | ||
|
|
||
| #: src/humanize/number.py:178 | ||
| #: src/humanize/number.py:183 |
There was a problem hiding this comment.
In my own projects, I tend to save filenames but not line numbers to PO files, to avoid such diff churn.
What do you think of changing the update script in another PR?
There was a problem hiding this comment.
I don't make translations myself, so if they're not useful I'll take your word for it and a PR is welcome :)
There was a problem hiding this comment.
Either the line numbers get outdated, so they are useless and get ignored, or they create churn in the history (which I could just accept but…)
So personally I find the filenames useful to be able to look up the context (source strings and even context lines from pgettext are not always enough), I tend to dislike the line numbers.
But you could open a ticket and ping translators to see their experience!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 11 11
Lines 796 798 +2
=======================================
+ Hits 792 794 +2
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Merci beaucoup ! |