Skip to content

add argument to filter package type#44

Merged
ido50 merged 1 commit into
python-morgan:mainfrom
philnewm:package-type-regex-argument
Dec 29, 2025
Merged

add argument to filter package type#44
ido50 merged 1 commit into
python-morgan:mainfrom
philnewm:package-type-regex-argument

Conversation

@philnewm
Copy link
Copy Markdown
Collaborator

@philnewm philnewm commented Sep 17, 2025

I would like an argument to filter which types of python packages I want to mirror.

This approach uses the regex string itself as a value for the command line argument, but there might be more user-friendly ways to achieve this functionality.

The default behavior to download whl, zip and tar.gz by not providing the argument stays untouched.

Closes #41

Comment thread morgan/__init__.py Outdated
@grische grische force-pushed the package-type-regex-argument branch from 3086c78 to fb72928 Compare September 29, 2025 10:41
Comment thread morgan/__init__.py Outdated
@philnewm philnewm requested a review from grische October 7, 2025 12:26
@ido50
Copy link
Copy Markdown
Collaborator

ido50 commented Oct 14, 2025

Looks like there are some conflicts now that need to be resolved. Also, does this make more sense as a configuration option in the config file, or as a command line flag as you implemented? I feel like some things are better defined in the configuration file for posterity, but not sure about this one. Let me know what you think.

@philnewm
Copy link
Copy Markdown
Collaborator Author

Good point with the config files.

To me, it would be preferable to have such options available as config options as well, but actually for all command line flags.

Currently, there are no command line flags configurable via the config files, I would want to keep the current implementations like --mirror-all-versions (#45) for now.

@philnewm philnewm force-pushed the package-type-regex-argument branch from b375c1f to 128f006 Compare October 15, 2025 15:30
@philnewm
Copy link
Copy Markdown
Collaborator Author

Fixed the tests

Comment thread morgan/__init__.py Outdated
@philnewm philnewm force-pushed the package-type-regex-argument branch 3 times, most recently from fd252e7 to 691d1c1 Compare October 17, 2025 08:31
@ido50
Copy link
Copy Markdown
Collaborator

ido50 commented Oct 17, 2025

@philnewm, can you rebase with main and force push? I tried fixing the conflicts with the --mirror-all-versions code via GitHub but it doesn't seem to have worked right for some reason. Thanks.

@philnewm
Copy link
Copy Markdown
Collaborator Author

Will take care of that today

@philnewm philnewm force-pushed the package-type-regex-argument branch from a5dcb09 to 9b608db Compare October 20, 2025 13:12
@philnewm
Copy link
Copy Markdown
Collaborator Author

Fixed the merge conflicts and tests

@ido50 ido50 merged commit 475b173 into python-morgan:main Dec 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirror sdists or wheels only

3 participants