fix: only download files for matching platforms#58
Merged
Conversation
If we always specify ".*linux.*x86_64" we will get wheels for musllinux as well as manylinux, even if the user explicitly specified a regex for only manylinux in morgan.ini This is a follow-up fix of python-morgan#26 that seems to have forgotten the if/else here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we always specify ".*linux.*x86_64" we will get wheels for musllinux as well as manylinux, even if the user explicitly specified a regex for only manylinux in morgan.ini.
This is a follow-up fix of #26 that seems to have forgotten the if/else here.
If I read the code correctly, this should have no negative impact on mixed Linux/Windows envs as every env is considered and each env will have a different entry in
_supported_platforms.