tests: fix class-scoped fixtures defined as instance methods - #1218
Open
polkorny wants to merge 1 commit into
Open
tests: fix class-scoped fixtures defined as instance methods#1218polkorny wants to merge 1 commit into
polkorny wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 9.1 deprecates class-scoped fixtures defined as plain
instance methods (PytestRemovedIn10Warning): attributes set on
selfin the fixture aren't visible to test methods, since pytestcreates a new instance per test but runs the fixture only once per
class.
Convert the
spec/content/finderfixtures intest_media_types_finders.py and the
spec/responses/finderfixtures in test_responses_finders.py to @classmethod, per
https://docs.pytest.org/en/stable/deprecations.html#class-scoped-fixture-as-instance-method