Add ImageText use_max_line_height()#9667
Open
radarhere wants to merge 1 commit into
Open
Conversation
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #1646. Alternative to #9581
Currently, the bottom of the bounding box of the text "A" is used to determine text line height.
#1646 found that other characters may have larger text height, leading to overlap between lines of text. While this is hard to see with most fonts, I found Great Vibes.
gives

This PR adds

use_max_line_height()to ImageText. If I call that, the largest bounding box from all of the characters in the given text is used (not all possible characters of the font). Using that method, I get