Open
Conversation
Use TypeVarId for mypy 1.11 Don't use is_noreturn
Redoubts
force-pushed
the
origin/patch-1
branch
from
0152f50 to
5e00c37
Compare
Member
|
out of curiosity, what is it that blocks you from bumping trio versions? If this is widespread maybe we might reluctantly keep this repo alive even after mypy adds the feature which makes it fully redundant on newer trio. |
Member
Author
|
I took a second look, and the trio.MultiError deprecation isn't as hard as I thought it would be. I'm less invested in this change, tho someone else may still want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple changes force some fixes in the plugin,
python/mypy#17304 took out an arg from
UninhabitedType, andpython/mypy#17311 introduced
TypeVarIdsI ran the tests, but let me know if there's anything else I should consider. I understand that newer trio versions make this plugin obsolete, but my code isn't there yet.
fixes #95