-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143952: Fix asyncio tools to work with the new remote debugging API #143954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-143952: Fix asyncio tools to work with the new remote debugging API #143954
Conversation
|
Hi, I'm wondering if we can add some tests to ensure we don't break this again in the future? |
|
Something's very wrong here. On it. |
|
Oh, okay. We have tests for tools but we don't import structures from cpython/Lib/test/test_asyncio/test_tools.py Lines 7 to 11 in 1b52ce8
|
|
OK I guess that's it for the fix itself! |
|
We'd want to keep these structures in sync later (we also don't have |
|
OK, it's not a problem. We would just have to pass sequences and we could use original structures. >>> from _remote_debugging import FrameInfo
>>> FrameInfo(range(4))
_remote_debugging.FrameInfo(filename=0, location=1, funcname=2, opcode=3) |
See GH-143955. |
pablogsal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! In retrospective this indeed was doomed to happen so I am glad that we are looking at this
psandpstree) #143952