Skip to content

gh-143984: Replace optparse with argparse in Lib/test/test_decimal.py #143983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonghuaroot wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −9
Open

gh-143984: Replace optparse with argparse in Lib/test/test_decimal.py #143983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fee791
gh-143984: Replace optparse with argparse in Lib/test/test_decimal.py
tonghuaroot Jan 18, 2026
359bcab
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 18, 2026
6cac27b
Merge branch 'main' into fix-decimal-optparse
tonghuaroot Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions Lib/test/test_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6028,15 +6028,16 @@ def test(arith=None, verbose=None, todo_tests=None, debug=None):


if __name__ == '__main__':
import optparse
p = optparse.OptionParser("test_decimal.py [--debug] [{--skip | test1 [test2 [...]]}]")
p.add_option('--debug', '-d', action='store_true', help='shows the test number and context before each test')
p.add_option('--skip', '-s', action='store_true', help='skip over 90% of the arithmetic tests')
(opt, args) = p.parse_args()

if opt.skip:
import argparse
parser = argparse.ArgumentParser(usage="test_decimal.py [--debug] [{--skip | test1 [test2 [...]]}]")
Comment on lines +6031 to +6032
Copy link
Member

@hugovk hugovk Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let argparse generate the usage, and it'll use colour for the different parts. And put the positional arg first, to match help output:

Suggested change
import argparse
parser = argparse.ArgumentParser(usage="test_decimal.py [--debug] [{--skip | test1 [test2 [...]]}]")
import argparse
parser = argparse.ArgumentParser()
parser.add_argument("tests", nargs="*", help="specific tests to run")

parser.add_argument('--debug', '-d', action='store_true', help='shows the test number and context before each test')
parser.add_argument('--skip', '-s', action='store_true', help='skip over 90%% of the arithmetic tests')
Comment on lines +6033 to +6034
Copy link
Member

@hugovk hugovk Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short option usually goes before the long, and this matches -h, --help. Also wrap long lines:

Suggested change
parser.add_argument('--debug', '-d', action='store_true', help='shows the test number and context before each test')
parser.add_argument('--skip', '-s', action='store_true', help='skip over 90%% of the arithmetic tests')
parser.add_argument(
"-d",
"--debug",
action="store_true",
help="shows the test number and context before each test",
)
parser.add_argument(
"-s",
"--skip",
action="store_true",
help="skip over 90%% of the arithmetic tests",
)`

parser.add_argument('tests', nargs='*', help='specific tests to run')
Copy link
Member

@hugovk hugovk Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parser.add_argument('tests', nargs='*', help='specific tests to run')

args = parser.parse_args()

if args.skip:
test(arith=False, verbose=True)
elif args:
test(arith=True, verbose=True, todo_tests=args, debug=opt.debug)
elif args.tests:
test(arith=True, verbose=True, todo_tests=args.tests, debug=args.debug)
else:
test(arith=True, verbose=True)
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2026-01-18-05-42-41.gh-issue-143984.n1imyc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Replace the usage of the deprecated optparse module with argparse in Lib/test/test_decimal.py.
Copy link
Member

@hugovk hugovk Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the issue, optparse is no longer deprecated.

Suggested change
Replace the usage of the deprecated optparse module with argparse in Lib/test/test_decimal.py.
Replace :mod:`optparse` with :mod:`argparse` in ``Lib/test/test_decimal.py``.

Loading