gh-148259: make list.remove atomic for non-trivial __eq__ comparison#148440
Open
KowalskiThomas wants to merge 1 commit intopython:mainfrom
Open
gh-148259: make list.remove atomic for non-trivial __eq__ comparison#148440KowalskiThomas wants to merge 1 commit intopython:mainfrom
list.remove atomic for non-trivial __eq__ comparison#148440KowalskiThomas wants to merge 1 commit intopython:mainfrom
Conversation
colesbury
reviewed
Apr 13, 2026
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Please add a NEWS entry (https://devguide.python.org/getting-started/pull-request-lifecycle/#how-to-add-a-news-entry) and fix the failing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR addresses the bug reported in #148259 where calling rich comparison may result in releasing the GIL which may result in
list.removeremoving the wrong item from thelist.list.removeis not atomic for non trivial__eq__comparisons #148259