Skip to content

gh-148487: Fix issues in test_add_python_opts#148507

Merged
StanFromIreland merged 3 commits intopython:mainfrom
StanFromIreland:check_add_python_opts
Apr 14, 2026
Merged

gh-148487: Fix issues in test_add_python_opts#148507
StanFromIreland merged 3 commits intopython:mainfrom
StanFromIreland:check_add_python_opts

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 13, 2026 •
edited
Loading

Apart from the wrong skip condition, the tests needed updating post 8a00c9a.

@StanFromIreland StanFromIreland added tests Tests in the Lib/test dir skip news labels Apr 13, 2026
@bedevere-app bedevere-app bot mentioned this pull request Apr 13, 2026
Closed
vstinner
vstinner reviewed Apr 13, 2026
View reviewed changes
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Apr 13, 2026

"_RegenSbom" failed with "HTTP error 503: Service Unavailable" on Windows CIs:

Download from https://www.bytereef.org/software/mpdecimal/releases/mpdecimal-2.5.1.tar.gz failed.

vstinner
vstinner approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 13, 2026

"_RegenSbom" failed with "HTTP error 503: Service Unavailable" on Windows CIs:

I can access the website now, I will try re-run.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Apr 13, 2026

Merge branch 'main' into check_add_python_opts

This action re-runs all CIs, it's not needed. I prefer to only re-run failed jobs, action available if you click on CI details (once all CI jobs completed, successfully or not).

@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 13, 2026

This action re-runs all CIs, it's not needed. I prefer to only re-run failed jobs, action available if you click on CI details (once all CI jobs completed, successfully or not).

I can do that next time. Tests are passing, it seems the site is working.

@StanFromIreland StanFromIreland merged commit 44f1b98 into python:main Apr 14, 2026
48 checks passed
@StanFromIreland StanFromIreland deleted the check_add_python_opts branch April 14, 2026 06:45
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Apr 14, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 14, 2026

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2026
@StanFromIreland @miss-islington
pythongh-148487: Fix issues in test_add_python_opts (pythonGH-148507)
67a8bd9 
(cherry picked from commit 44f1b98)

Co-authored-by: Stan Ulbrych <stan@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 14, 2026

GH-148545 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 14, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 14, 2026

GH-148546 is a backport of this pull request to the 3.13 branch.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Apr 14, 2026

I backported the change to 3.13 and 3.14 which are also affected.

vstinner added a commit that referenced this pull request Apr 14, 2026
@vstinner @StanFromIreland
[3.13] gh-148487: Fix issues in test_add_python_opts (#148507) (#14…
63c9aa6 
…8546)

gh-148487: Fix issues in `test_add_python_opts` (#148507)

(cherry picked from commit 44f1b98)

Co-authored-by: Stan Ulbrych <stan@python.org>
vstinner pushed a commit that referenced this pull request Apr 14, 2026
@miss-islington @StanFromIreland
[3.14] gh-148487: Fix issues in test_add_python_opts (GH-148507) (#…
314f12c 
…148545)

gh-148487: Fix issues in `test_add_python_opts` (GH-148507)
(cherry picked from commit 44f1b98)

Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@graingert graingert Awaiting requested review from graingert

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @vstinner