gh-87904: Report the public module name in curses types and exceptions#152341
Merged
Conversation
…eptions The curses C types and exceptions now set their tp_name to the public module, so __module__, repr() and help() report curses.window, curses.complexchar, curses.complexstr, curses.screen, curses.error, curses.panel.panel and curses.panel.error instead of the underscore extension modules. This matches the convention used by decimal.Decimal, collections.deque and sqlite3.Error. The types are unchanged objects, still reachable through the _curses and _curses_panel modules. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curses C types and exceptions now set their
tp_nameto the public module, so__module__,repr()andhelp()reportcurses.window,curses.complexchar,curses.complexstr,curses.screen,curses.error,curses.panel.panelandcurses.panel.errorinstead of the underscore extension modules.This matches the convention already used by
decimal.Decimal,collections.dequeandsqlite3.Error, and makes the documented public names usable in tracebacks andhelp(). The types are unchanged objects, still reachable through_cursesand_curses_panel.