gh-152358: Fix hash() of annotationlib.ForwardRef with unhashable value#152360
Open
tonghuaroot wants to merge 1 commit into
Open
gh-152358: Fix hash() of annotationlib.ForwardRef with unhashable value#152360tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForwardRef.__eq__andForwardRef.__hash__already compare and hash theunhashable
__globals__and__cell__fields by identity, but__owner__and__extra_names__were used directly. Because a forward reference can hold anarbitrary, possibly unhashable, value -- a value embedded in an annotation, or
an unhashable owner --
hash()raisedTypeErrorwhile__eq__succeeded, adata model invariant violation that also broke storing forward references in
sets and as dict keys.
This applies the same
id()-based treatment to__owner__and__extra_names__in both
__eq__and__hash__, mirroring the__cell__fix in gh-143831 andmaking
__hash__total. Comparing these fields by identity is consistent withthe existing
__globals__/__cell__handling, and two forward referencesderived from the same annotation share the same objects, so they still compare
equal.