Skip to content

[peewee] type all "database" call arguments#15961

Closed
Psycojoker wants to merge 1 commit into
python:mainfrom
Psycojoker:peewee-type-all-database-arguments
Closed

[peewee] type all "database" call arguments#15961
Psycojoker wants to merge 1 commit into
python:mainfrom
Psycojoker:peewee-type-all-database-arguments

Conversation

@Psycojoker

@Psycojoker Psycojoker commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Hello,

Peewee comes with the concept of both a Database object a DatabaseProxy which is a database that doesn't require a connection to be opened immediately: https://docs.peewee-orm.com/en/latest/peewee/api.html#DatabaseProxy

Therefore, I've create a combine type for both and then typed all arguments to method with this new type:

_DatabaseType: TypeAlias = Database | DatabaseProxy

Here are the reference from peewee's documentation:

image image image

https://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.execute

image

https://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.iterator

image

https://docs.peewee-orm.com/en/latest/peewee/api.html#SelectBase

image

https://docs.peewee-orm.com/en/latest/peewee/api.html#SelectBase.count

image

https://docs.peewee-orm.com/en/latest/peewee/api.html#SelectBase.exists

image

https://docs.peewee-orm.com/en/latest/peewee/api.html#Database.init

For some reason I can't find the "aexecute" in the .pyi file, is it normal? Should I had it myself? I would assume that some tooling was doing this job automatically?

image https://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.aexecute

Kind regards,

@Psycojoker Psycojoker force-pushed the peewee-type-all-database-arguments branch from df7da56 to 436ad2c Compare June 28, 2026 00:12
@github-actions

This comment has been minimized.

@Psycojoker Psycojoker force-pushed the peewee-type-all-database-arguments branch from 3b7f56b to 0dd3786 Compare June 28, 2026 00:40
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Psycojoker

Copy link
Copy Markdown
Contributor Author

Closed in favor of #15911 (comment) (and the work is likely going to be upstream in peewee itself)

@Psycojoker Psycojoker closed this Jun 28, 2026
@Psycojoker Psycojoker deleted the peewee-type-all-database-arguments branch June 28, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant