fnmatch calls os.path.normcase(arg)#15963
Open
hunterhogan wants to merge 3 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: setuptools (https://github.com/pypa/setuptools)
+ setuptools/glob.py:106: error: Unused "type: ignore[return-value]" comment [unused-ignore]
|
Contributor
Author
Link to code above. I feel like this suggests that my proposed type annotations are a step in the right direction because they seem to be more aligned with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fnmatch.fnmatch,fnmatch.filter, andfnmatch.filterfalseeach pass their parameters,nameandpat, toos.path.casenormbefore operating on the parameters.typeshed/stdlib/posixpath.pyi
Lines 125 to 134 in cc36aca
Therefore, the three fnmatch functions' parameters are
AnyOrLiteralStr | PathLike[AnyStr]instead ofAnyStr.If any parameter or parameter's element in
filterorfilterfalseisPathLike[AnyStr], then the return is limited tolist[AnyStr], otherwise it is the supersetlist[AnyOrLiteralStr].