Conversation
Keep only restructure + bootstrap for now. Justfile multi-cloud routing (kubeconfig, deploy, deploy-module) will come in a later PR.
Contributor
|
I believe the changes are necessary, good that you took over this :) as you are working on this, break the base module down so we can have a: and easily. We can have the aws-specific stuff on one cluster and the gcp-specific stuff into another.. Maybe we should get rid of the base entierly, and have everything defined as modules that should be applied in sequence. I guess this would make this a more correct and flexible solutioin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Kubernetes base restructure: Split
base/kubernetes/into provider-agnostic base + provider overlays.kubectl kustomize base/kubernetes/output is identical before and after — zero diff.Bootstrap multi-cloud routing:
bootstrap-state.shreads the cluster'scloudfield and routes tobootstrap-state-gcp.shfor GCP clusters (GCS bucket, no DynamoDB needed). AWS path unchanged.Path fixups: Updated justfile git-cache deploy path + doc references to match new structure.
Next steps
deploy-moduleterraform init routing (S3 vs GCS backend)deploy/kubeconfigmulti-cloud routing in justfilemodules/gke/)