Support whole-number float exponents in ReplacePowWithMulPass (#18851)#18851
Open
khazaei wants to merge 1 commit intopytorch:mainfrom
Open
Support whole-number float exponents in ReplacePowWithMulPass (#18851)#18851khazaei wants to merge 1 commit intopytorch:mainfrom
khazaei wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18851
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ 2 Pending, 2 Unrelated FailuresAs of commit db78fae with merge base 75c677f ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@khazaei has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100695654. |
This PR needs a
|
hsharma35
approved these changes
Apr 14, 2026
meta-codesync
bot
changed the title
khazaei
force-pushed
the
export-D100695654
branch
from
cc464b5 to
9b8346e
Compare
khazaei
pushed a commit
to khazaei/executorch
that referenced
this pull request
Apr 14, 2026
…h#18851) Summary: Extend `ReplacePowWithMulPass` to accept float exponents that are whole numbers (e.g., 2.0, 3.0, 4.0) in addition to integer exponents. Previously the pass only matched `int` typed exponents, causing it to miss valid optimization opportunities when the exponent was a float with no fractional part. Changes: - Broaden the type check from `isinstance(_, int)` to `isinstance(_, (int, float))` - Add a guard to reject non-whole-number floats (e.g., 1.5, 0.5) - Convert validated float exponents to `int` before proceeding - Update docstring to document the new behavior Reviewed By: hsharma35, mcremon-meta Differential Revision: D100695654
khazaei
pushed a commit
to khazaei/executorch
that referenced
this pull request
Apr 14, 2026
…h#18851) Summary: Extend `ReplacePowWithMulPass` to accept float exponents that are whole numbers (e.g., 2.0, 3.0, 4.0) in addition to integer exponents. Previously the pass only matched `int` typed exponents, causing it to miss valid optimization opportunities when the exponent was a float with no fractional part. Changes: - Broaden the type check from `isinstance(_, int)` to `isinstance(_, (int, float))` - Add a guard to reject non-whole-number floats (e.g., 1.5, 0.5) - Convert validated float exponents to `int` before proceeding - Update docstring to document the new behavior Reviewed By: hsharma35, mcremon-meta Differential Revision: D100695654
khazaei
force-pushed
the
export-D100695654
branch
from
9b8346e to
e6267b1
Compare
khazaei
pushed a commit
to khazaei/executorch
that referenced
this pull request
Apr 14, 2026
…h#18851) Summary: Pull Request resolved: pytorch#18851 Extend `ReplacePowWithMulPass` to accept float exponents that are whole numbers (e.g., 2.0, 3.0, 4.0) in addition to integer exponents. Previously the pass only matched `int` typed exponents, causing it to miss valid optimization opportunities when the exponent was a float with no fractional part. Changes: - Broaden the type check from `isinstance(_, int)` to `isinstance(_, (int, float))` - Add a guard to reject non-whole-number floats (e.g., 1.5, 0.5) - Convert validated float exponents to `int` before proceeding - Update docstring to document the new behavior Reviewed By: hsharma35, mcremon-meta Differential Revision: D100695654
khazaei
force-pushed
the
export-D100695654
branch
from
e6267b1 to
6b1da40
Compare
…h#18851) Summary: Pull Request resolved: pytorch#18851 Extend `ReplacePowWithMulPass` to accept float exponents that are whole numbers (e.g., 2.0, 3.0, 4.0) in addition to integer exponents. Previously the pass only matched `int` typed exponents, causing it to miss valid optimization opportunities when the exponent was a float with no fractional part. Changes: - Broaden the type check from `isinstance(_, int)` to `isinstance(_, (int, float))` - Add a guard to reject non-whole-number floats (e.g., 1.5, 0.5) - Convert validated float exponents to `int` before proceeding - Update docstring to document the new behavior Reviewed By: hsharma35, mcremon-meta Differential Revision: D100695654
khazaei
force-pushed
the
export-D100695654
branch
from
6b1da40 to
db78fae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extend
ReplacePowWithMulPassto accept float exponents that are whole numbers(e.g., 2.0, 3.0, 4.0) in addition to integer exponents. Previously the pass only
matched
inttyped exponents, causing it to miss valid optimization opportunitieswhen the exponent was a float with no fractional part.
Changes:
isinstance(_, int)toisinstance(_, (int, float))intbefore proceedingReviewed By: hsharma35, mcremon-meta
Differential Revision: D100695654