Skip to content

Arm backend: aot_arm_compiler.py support BundleIO output file without a path#18871

Open
zingo wants to merge 1 commit intopytorch:mainfrom
zingo:Arm-backend-aot_arm_compiler.py-support-budleio-output-without-a-path
Open

Arm backend: aot_arm_compiler.py support BundleIO output file without a path#18871
zingo wants to merge 1 commit intopytorch:mainfrom
zingo:Arm-backend-aot_arm_compiler.py-support-budleio-output-without-a-path

Conversation

@zingo
Copy link
Copy Markdown
Collaborator

@zingo zingo commented Apr 14, 2026

BundleIO output generation needed the specified output file name to be supplied with a folder, so if you wanted to output a file in the current folder you needed to add "./" in front of the file name like "./file.bpte" this change fixes this problem, the normal .pte generation already supported this.

cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

BundleIO output generation needed a the output file to exist in a
folder, so if you wanted to output a file in the current folder you
neeed to add "./" in front of the file name like "./file.bpte" this
fixes this problem, normal .pte already support this.

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I8cb941cc068383619a51aaf79e88b59b7e4ad901
Copilot AI review requested due to automatic review settings April 14, 2026 12:48
@zingo zingo requested a review from digantdesai as a code owner April 14, 2026 12:48
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18871

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 1 Pending, 3 Unrelated Failures

As of commit 7725f0e with merge base 2c545f8 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2026
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 14, 2026
@zingo zingo added the release notes: none Do not include this in the release notes label Apr 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes BundleIO .bpte output generation in the ARM AOT compiler so that specifying an output filename in the current working directory (e.g., file.bpte) works without requiring a ./ prefix.

Changes:

  • Guard os.makedirs(output_dir, exist_ok=True) so it’s only called when os.path.dirname(output_name) is non-empty for BundleIO output saving.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants