Arm backend: aot_arm_compiler.py support BundleIO output file without a path#18871
Open
zingo wants to merge 1 commit intopytorch:mainfrom
Open
Conversation
BundleIO output generation needed a the output file to exist in a folder, so if you wanted to output a file in the current folder you neeed to add "./" in front of the file name like "./file.bpte" this fixes this problem, normal .pte already support this. Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com> Change-Id: I8cb941cc068383619a51aaf79e88b59b7e4ad901
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18871
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 1 Pending, 3 Unrelated FailuresAs of commit 7725f0e with merge base 2c545f8 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes BundleIO .bpte output generation in the ARM AOT compiler so that specifying an output filename in the current working directory (e.g., file.bpte) works without requiring a ./ prefix.
Changes:
- Guard
os.makedirs(output_dir, exist_ok=True)so it’s only called whenos.path.dirname(output_name)is non-empty for BundleIO output saving.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BundleIO output generation needed the specified output file name to be supplied with a folder, so if you wanted to output a file in the current folder you needed to add "./" in front of the file name like "./file.bpte" this change fixes this problem, the normal .pte generation already supported this.
cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell