[Pallas] Skip trivial reduction mask when RDIM size equals actual dim#1993
Merged
[Pallas] Skip trivial reduction mask when RDIM size equals actual dim#1993
Conversation
ad8be77 to
9b9ac7e
Compare
AmesingFlank
approved these changes
Apr 9, 2026
9b9ac7e to
292b3c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RDIM_SIZEequal to the actual dimension size (no rounding), the reduction mask is always true and can be skipped entirelybackend.static_rdim_size(numel)againstnumel, which naturally handles both backendsnumel > 0to preserve correct behavior for zero-size reductions (static_rdim_size(0)returns 1 vianext_power_of_2, which would incorrectly skip the mask)Before (unnecessary mask for Pallas on non-power-of-2 dim like 1000):
After (no mask — clean and correct):