[Pallas] Fix fori_loop multi-dim inner loop index unflattening#1995
Closed
thcmbs wants to merge 1 commit intopytorch:mainfrom
Closed
[Pallas] Fix fori_loop multi-dim inner loop index unflattening#1995thcmbs wants to merge 1 commit intopytorch:mainfrom
thcmbs wants to merge 1 commit intopytorch:mainfrom
Conversation
Contributor
|
FYI, there are some comments under #1917. We see slightly better performance with double fori_loop, and it also seems a more natural way to implement this. |
Collaborator
Author
|
Thanks for sharing! Given the perf diff, there is no debate :) |
Collaborator
Author
|
Closing given that #1917 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix out-of-bounds DMA access when fori_loop iterates over multiple inner block dimensions
The flat
_jloop variable was used directly for all dimensions' offsets; now we unflatten it into per-dimension indices (_j_0,_j_1, ...) via divmod decomposition