[Better engineering]Make vllm commit consistent across benchmark tests#131
Open
[Better engineering]Make vllm commit consistent across benchmark tests#131
Conversation
huydhn
reviewed
Jan 9, 2026
| fi | ||
| fi | ||
|
|
||
| if [[ "${ALL_IMAGES_EXIST}" == "true" ]]; then |
Contributor
There was a problem hiding this comment.
This ALL_IMAGES_EXIST might not work in practice because I remember the Docker image for different platforms are maintained differently:
- If HPU (not that important when comparing to CUDA) build fail, it might take a long time to get fix. And if I read the code here correctly, this would leave us stuck on an older commit (the last commit HPU was built successfully)
- They might be build at different schedule. HPU and arm64 CPU build for example were in this bucket before where they were build daily or something (IIRC). Again, the loop needs to go back to much older commit to find a common commit.
What do you think about returning the list of commit for each of these platform independent? For example, 1 for CUDA, 1 for ROCm, etc.. IMO, this should be a good middle ground because the perf results are used per platform anyway, i.e. no ROCm vs CUDA comparison. With this, you can fold the vllm_commit into the output of generate_vllm_benchmark_matrix.py, and potentially move the Docker check logic here into the Python script too, which is usually easier to maintain than CI bash
Contributor
Author
There was a problem hiding this comment.
i see, we can def do thatm let me modify this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
due to the machine queue time, vllm benchmark jobs run benchmark based on the latest vllm can be dependent on different vllm commit,
we want this to be consistent
Details
sometimes the latest commit from vllm does not fully generate all docker imgs for all hardwares, so in order to not make tests fail, before run benchmark, we want to find the commit that has docker img binaries for all hardwares:
1.If user provides vllm_commit input → Use that commit directly (user's responsibility to ensure images exist)
2. autoL Iterate through the last 100 commits and find the first one that has Docker images available for all platforms being benchmarked
Test run:
https://github.com/pytorch/pytorch-integration-testing/actions/runs/20861018484