Skip to content

fix: copy caller-supplied defaults instead of aliasing - #150

Merged
djhoese merged 1 commit into
pytroll:mainfrom
maxrjones:fix-defaults-aliasing
Jul 27, 2026
Merged

fix: copy caller-supplied defaults instead of aliasing#150
djhoese merged 1 commit into
pytroll:mainfrom
maxrjones:fix-defaults-aliasing

Conversation

@maxrjones

@maxrjones maxrjones commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This PR isolates the bug fix that @djhoese recommended in #149 (comment) into a distinct PR. I assumed the test that aliased the callers argument was correct; in fact that was a bug in both the code and tests. This PR makes sure that the caller supplied defaults are always copied.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.44%. Comparing base (7b90e4d) to head (a92210b).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   98.28%   98.44%   +0.15%     
==========================================
  Files           6        6              
  Lines         759      772      +13     
==========================================
+ Hits          746      760      +14     
+ Misses         13       12       -1     
Flag Coverage Δ
unittests 98.44% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djhoese djhoese left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhoese
djhoese merged commit de263a2 into pytroll:main Jul 27, 2026
10 checks passed
@maxrjones
maxrjones deleted the fix-defaults-aliasing branch July 27, 2026 15:51
@djhoese djhoese added the bug Something isn't working label Jul 27, 2026
@djhoese djhoese self-assigned this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants