Skip to content

Refactor message decoding, make keepalive universal#82

Open
mraspaud wants to merge 7 commits intopytroll:mainfrom
mraspaud:refactor-message-decoding
Open

Refactor message decoding, make keepalive universal#82
mraspaud wants to merge 7 commits intopytroll:mainfrom
mraspaud:refactor-message-decoding

Conversation

@mraspaud
Copy link
Member

This remove the usage of dict for creating messages from strings or deserialisation, deprecates rawstr, introduces the from_string class method.
Also the keepalive options are now systematically applied to all sockets if defined.

Also introduced `from_string` and deprecates the `rawstr` argument of
Message instantiation
@mraspaud mraspaud requested a review from pnuu February 26, 2026 11:30
@mraspaud mraspaud self-assigned this Feb 26, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 91.48936% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.08%. Comparing base (b041234) to head (c5bdb94).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
posttroll/message.py 86.04% 6 Missing ⚠️
posttroll/backends/zmq/subscriber.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   88.73%   88.08%   -0.66%     
==========================================
  Files          26       26              
  Lines        2611     2652      +41     
==========================================
+ Hits         2317     2336      +19     
- Misses        294      316      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant